Skip to content

tracer: add CEL sampler to OpenTelemetry#38182

Merged
yanavlasov merged 21 commits into
envoyproxy:mainfrom
zirain:cel_sampler
Feb 26, 2025
Merged

tracer: add CEL sampler to OpenTelemetry#38182
yanavlasov merged 21 commits into
envoyproxy:mainfrom
zirain:cel_sampler

Conversation

@zirain

@zirain zirain commented Jan 24, 2025

Copy link
Copy Markdown
Member

Commit Message: add CEL sampler to OpenTelemetry tracer
Additional Description: This is initial PR, there are plans to support request headers in the next step, and any suggestions are welcome. cc @wbpcode
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@zirain
init cel sampler
473ac4e 
Signed-off-by: zirain <[email protected]>
@zirain
zirain requested a review from yanavlasov as a code owner January 24, 2025 12:17
@repokitteh-read-only repokitteh-read-only Bot added api deps Approval required for changes to Envoy's external dependencies labels Jan 24, 2025
@repokitteh-read-only

repokitteh-read-only Bot commented Jan 24, 2025

Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @wbpcode
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #38182 was opened by zirain.

see: more, trace.

zirain added 4 commits January 24, 2025 20:46
@zirain
precheck
9d401c5 
Signed-off-by: zirain <[email protected]>
@zirain
precheck
852797d 
Signed-off-by: zirain <[email protected]>
@zirain
precheck
9a3cfa4 
Signed-off-by: zirain <[email protected]>
@zirain
prechecks
360f3fe 
Signed-off-by: zirain <[email protected]>
@moderation

moderation commented Jan 26, 2025

Copy link
Copy Markdown
Contributor

/lgtm deps

Metadata changes only

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Jan 26, 2025
@alyssawilk

alyssawilk commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

ping @wbpcode

@adisuissa

adisuissa commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

@wbpcode PTAL

wbpcode
wbpcode reviewed Feb 5, 2025
View reviewed changes

@wbpcode wbpcode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am basically fine to the API. Please ensure the code owners are willing to maintain this new extension. Thanks.

Comment thread api/envoy/extensions/tracers/opentelemetry/samplers/v3/cel_sampler.proto
@wbpcode

wbpcode commented Feb 5, 2025

Copy link
Copy Markdown
Member

@AlexanderEllis @yanavlasov

@wbpcode

wbpcode commented Feb 5, 2025

Copy link
Copy Markdown
Member

/wait-any

@repokitteh-read-only repokitteh-read-only Bot added deps Approval required for changes to Envoy's external dependencies and removed waiting:any labels Feb 6, 2025
yanavlasov
yanavlasov reviewed Feb 6, 2025
View reviewed changes

@yanavlasov yanavlasov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait-any

Comment thread api/envoy/extensions/tracers/opentelemetry/samplers/v3/cel_sampler.proto
@zirain
required
f9e30d5 
Signed-off-by: zirain <[email protected]>
zirain added 2 commits February 7, 2025 09:01
@zirain
import
113a662 
Signed-off-by: zirain <[email protected]>
@zirain
update
322514a 
Signed-off-by: zirain <[email protected]>
@yanavlasov

yanavlasov commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

/wait-any

@zirain
fix format-api
06e531b 
Signed-off-by: zirain <[email protected]>
@zirain
remove unused
311043a 
Signed-off-by: zirain <[email protected]>
@zirain
more test
e7512f1 
Signed-off-by: zirain <[email protected]>
@zirain
fix BUILD
890d56b 
Signed-off-by: zirain <[email protected]>
@zirain
mark as wip
c9f93a3 
Signed-off-by: zirain <[email protected]>
@zirain
format-api
bbdfe45 
Signed-off-by: zirain <[email protected]>
@zirain

zirain commented Feb 14, 2025

Copy link
Copy Markdown
Member Author

I have no idea why compile_time_options failed. 😞

yanavlasov
yanavlasov requested changes Feb 14, 2025
View reviewed changes

@yanavlasov yanavlasov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/wait

Comment thread test/extensions/tracers/opentelemetry/samplers/cel/cel_sampler_test.cc Outdated
@zirain
use cel_expr_parsed
dcbf596 
Signed-off-by: zirain <[email protected]>
@zirain
zirain requested a review from yanavlasov February 17, 2025 13:06
wbpcode
wbpcode reviewed Feb 20, 2025
View reviewed changes

@wbpcode wbpcode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@KBaichoo

KBaichoo commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

seems like this is ready for merge as moderation lgtmed deps. @yanavlasov for final pass

@yanavlasov
yanavlasov merged commit 856f3de into envoyproxy:main Feb 26, 2025
@zirain
zirain deleted the cel_sampler branch February 26, 2025 19:49
@zirain zirain mentioned this pull request Feb 28, 2025
Merged
wbpcode pushed a commit that referenced this pull request Mar 12, 2025
@zirain
tracer: support request in cel sampler (#38617)
d722bf2 
<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
[email protected] where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)
-->

Commit Message: this's a follow up for
#38182, make `request` work on
cel sampler, cc @wbpcode
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

---------

Signed-off-by: zirain <[email protected]>
jewertow pushed a commit to jewertow/envoy that referenced this pull request Apr 2, 2025
@zirain @jewertow
tracer: add CEL sampler to OpenTelemetry (envoyproxy#38182)
2087607 
This is initial PR, there are plans to support
request headers in the next step, and any suggestions are welcome.

---------

Signed-off-by: zirain <[email protected]>
jewertow pushed a commit to jewertow/envoy that referenced this pull request Apr 2, 2025
@zirain @jewertow
tracer: support request in cel sampler (envoyproxy#38617)
c59d098 
<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
[email protected] where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)
-->

Commit Message: this's a follow up for
envoyproxy#38182, make `request` work on
cel sampler, cc @wbpcode
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

---------

Signed-off-by: zirain <[email protected]>
agrawroh pushed a commit to agrawroh/envoy that referenced this pull request Apr 9, 2025
@zirain @agrawroh
tracer: add CEL sampler to OpenTelemetry (envoyproxy#38182)
2eec3f7 
This is initial PR, there are plans to support
request headers in the next step, and any suggestions are welcome.

---------

Signed-off-by: zirain <[email protected]>
agrawroh pushed a commit to agrawroh/envoy that referenced this pull request Apr 9, 2025
@zirain @agrawroh
tracer: support request in cel sampler (envoyproxy#38617)
6027b9e 
<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
[email protected] where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)
-->

Commit Message: this's a follow up for
envoyproxy#38182, make `request` work on
cel sampler, cc @wbpcode
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

---------

Signed-off-by: zirain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbpcode wbpcode wbpcode left review comments
@yanavlasov yanavlasov yanavlasov approved these changes

Assignees

@moderation moderation

@yanavlasov yanavlasov

@wbpcode wbpcode

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zirain @moderation @alyssawilk @adisuissa @wbpcode @yanavlasov @KBaichoo