Skip to content

opencensus: delete opencensus tracer#37508

Merged
alyssawilk merged 4 commits intoenvoyproxy:mainfrom
ggreenway:opencensus-rm
Dec 5, 2024
Merged

opencensus: delete opencensus tracer#37508
alyssawilk merged 4 commits intoenvoyproxy:mainfrom
ggreenway:opencensus-rm

Conversation

@ggreenway
Copy link
Copy Markdown
Member

@ggreenway ggreenway commented Dec 4, 2024 •
edited
Loading

Additional Description: This has been deprecated for several releases, and the upstream dependency is no longer maintained.
Risk Level: Low; this was marked as deprecated in 1.28 and was supposed to be removed in 1.30
Fixes #9958
Progress on #11816

@ggreenway @phlax
opencensus: delete opencensus tracer
014ad83 
This has been deprecated for several releases, and the upstream
dependency is no longer maintained.

Signed-off-by: Greg Greenway <[email protected]>
Co-authored-by: Ryan Northey <[email protected]>
@repokitteh-read-only repokitteh-read-only bot added v2-freeze api deps Approval required for changes to Envoy's external dependencies labels Dec 4, 2024
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Dec 4, 2024

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).
CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @alyssawilk
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #37508 was opened by ggreenway.

see: more, trace.

@ggreenway
add changelog
5a4dde3 
Signed-off-by: Greg Greenway <[email protected]>
alyssawilk
alyssawilk previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At long last :-)

@ggreenway ggreenway mentioned this pull request Dec 4, 2024
Closed
@ggreenway
fix build
b7968e1 
Signed-off-by: Greg Greenway <[email protected]>
@repokitteh-read-only repokitteh-read-only bot removed the api label Dec 5, 2024
@moderation
Copy link
Copy Markdown
Contributor

moderation commented Dec 5, 2024

/lgtm deps

Yay.

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Dec 5, 2024
adisuissa
adisuissa reviewed Dec 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the first major API breaking change that I'm encountering...
I guess there's a first time for everything :)
/lgtm api

@alyssawilk alyssawilk merged commit e456b9b into envoyproxy:main Dec 5, 2024
sayboras added a commit to cilium/cilium that referenced this pull request Feb 20, 2025
@sayboras
envoy: Remove service/trace/v3 import
0dd30f9 
This service/trace/v3 API is removed in upstream envoy.

Relates: envoyproxy/envoy#37508
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras mentioned this pull request Feb 20, 2025
Merged
github-merge-queue bot pushed a commit to cilium/cilium that referenced this pull request Feb 21, 2025
@sayboras
envoy: Remove service/trace/v3 import
1e3e9ef 
This service/trace/v3 API is removed in upstream envoy.

Relates: envoyproxy/envoy#37508
Signed-off-by: Tam Mach <[email protected]>
itspooya pushed a commit to itspooya/cilium that referenced this pull request Feb 25, 2025
@sayboras @itspooya
envoy: Remove service/trace/v3 import
dc3fe4a 
This service/trace/v3 API is removed in upstream envoy.

Relates: envoyproxy/envoy#37508
Signed-off-by: Tam Mach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adisuissa adisuissa adisuissa left review comments

@wbpcode wbpcode wbpcode approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

+1 more reviewer

@alyssawilk alyssawilk alyssawilk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@moderation moderation

@adisuissa adisuissa

@alyssawilk alyssawilk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tracing: Transition to OpenTelemetry from OpenTracing and OpenCensus

5 participants

@ggreenway @moderation @adisuissa @wbpcode @alyssawilk