drain_manager: Unclean Revert of "HTTP2 Proactive GOAWAY on Drain - Preamble (#17026)"#37465
Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom Dec 9, 2024
Merged
drain_manager: Unclean Revert of "HTTP2 Proactive GOAWAY on Drain - Preamble (#17026)"#37465alyssawilk merged 3 commits intoenvoyproxy:mainfrom
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
Conversation
alyssawilk
force-pushed
the
drain
branch
2 times, most recently
from
ec49975 to
58f7f08
Compare
…roxy#17026)" This reverts commit 96dd735. Signed-off-by: Alyssa Wilk <[email protected]>
alyssawilk
requested review from
RyanTheOptimist,
abeyad,
fredyw and
mattklein123
as code owners
zuercher
reviewed
Dec 4, 2024
|
|
||
| ASSERT(!drain_tick_timer_); | ||
| const std::chrono::seconds drain_delay(server_.options().drainTime()); | ||
| drain_tick_timer_ = server_.dispatcher().createTimer(drain_complete_cb); |
Member
There was a problem hiding this comment.
Just noting that at 96dd735, we used to set draining_ = true -- is that not necessary in the revert? I see the field still exists.
Contributor
Author
There was a problem hiding this comment.
setting it down on line 83 to preserve the (maybe not even relevant) fix in #31452
hence the unclean revert
zuercher
previously approved these changes
Dec 4, 2024
Signed-off-by: Alyssa Wilk <[email protected]>
Signed-off-by: Alyssa Wilk <[email protected]>
zuercher
approved these changes
Dec 9, 2024
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Feb 6, 2025
…rain - Preamble (envoyproxy#17026)" (envoyproxy#37465)" This reverts commit 072831e. Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov
added a commit
that referenced
this pull request
Feb 11, 2025
…rain - Preamble (#17026)" (#37465)" (#38333) Commit Message: This reverts commit 072831e. Revert in PR-37465 created problems for boundary proxy for Google partner cloud, as it depends on the reverted internal API `addOnDrainCloseCb`. Boundary proxy is open source and Google cloud partners will be unable to build OSS version, since it depends on OSS Envoy. Putting back the reverted code for now, as it is unclear what exactly can be removed from Envoy at this point. Risk Level: Low Testing: Unit tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: Yan Avlasov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 96dd735.
96dd735
was a precursor to
#16201
which never landed.
Unwinding the change
envoyproxy/envoy-mobile#176