[ext_proc] Ext proc half close on destroy and defer reset till trailers received. #37083
Merged
tyxia merged 5 commits intoenvoyproxy:mainfrom Nov 11, 2024
Merged
Conversation
…reset till trailers received or timer out Signed-off-by: Xin Zhuang <[email protected]>
Signed-off-by: Xin Zhuang <[email protected]>
Signed-off-by: Xin Zhuang <[email protected]>
stevenzzzz
requested review from
mattklein123,
tyxia and
yanavlasov
as code owners
stevenzzzz
changed the title
Contributor
Author
|
/retest |
stevenzzzz
changed the title
Signed-off-by: Xin Zhuang <[email protected]>
Signed-off-by: Xin Zhuang <[email protected]>
tyxia
approved these changes
Nov 11, 2024
Member
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
LGTM, Thanks.
This is same as internal change, right?
Contributor
Author
|
yeah, it's a patch from the internal CL. |
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Dec 12, 2024
… trailers received. (envoyproxy#37083)" This reverts commit 0b90f64. Signed-off-by: Yan Avlasov <[email protected]>
yanavlasov
added a commit
that referenced
this pull request
Dec 20, 2024
… trailers received. (#37083)" (#37639) This PR is **suspected** of causing instability in prod. The cause is not yet fully diagnosed, but it is reverted as a safety measure. Risk Level: Low Testing: Unit tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Yan Avlasov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: [ext_proc] Ext proc half close on destroy and defer reset till trailers received.
Additional Description: In Grpc, the trailers carries the grpc-status header terminates a rpc stream. Our current flow ignores the trailers by closeStream and resetStream all together, the later resetStream call would signal the remote server a CANCEL, while clean the sidestream and ignore any possible trailers that might have been sent by ext_proc server.
This PR would defer the cleanup of the side stream till a trailers been received, or till a cleanup timer fires.
Risk Level: medium
Testing: unit tests
Docs Changes:
Release Notes:
Platform Specific Features: