runtime: load rtds bool correctly as true/false instead of 1/0#36044
Merged
alyssawilk merged 10 commits intoenvoyproxy:mainfrom Sep 11, 2024
Merged
runtime: load rtds bool correctly as true/false instead of 1/0#36044alyssawilk merged 10 commits intoenvoyproxy:mainfrom
alyssawilk merged 10 commits intoenvoyproxy:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Load RTDS boolean config correctly as true/false instead of 1/0
Additional Description: Currently, RTDS boolean values are being loaded as
1or0, which is inconsistent with the expectedtrueorfalsevalues. This discrepancy needs to be corrected so that boolean values are consistently loaded and represented astrueorfalse. For further details, please refer to the issue comment where this inconsistency is discussed.Risk Level: Low (to be consistent with initially loaded true/false value)
Testing: new Unit Test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Fixes #Issue] #35762