mobile: Fix missing logging output in Swift integration tests#36040
Merged
fredyw merged 9 commits intoenvoyproxy:mainfrom Sep 9, 2024
Merged
mobile: Fix missing logging output in Swift integration tests#36040fredyw merged 9 commits intoenvoyproxy:mainfrom
fredyw merged 9 commits intoenvoyproxy:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Swift,
printgoes to stdout buffering. The fix is to flush thestdoutandstderrbefore the end of the test.See swiftlang/swift-corelibs-xctest#422 (comment)
Risk Level: low (tests only)
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a