opentracing: remove legacy open tracing extension#35418
opentracing: remove legacy open tracing extension#35418alyssawilk merged 2 commits intoenvoyproxy:mainfrom
Conversation
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Alyssa Wilk <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
repokitteh-read-only
bot
removed
api
deps
|
/docs |
|
Docs for this Pull Request will be rendered here: The docs are (re-)rendered each time the CI |
| // [#protodoc-title: Dynamically loadable OpenTracing tracer] | ||
|
|
||
| // DynamicOtConfig is used to dynamically load a tracer from a shared library | ||
| // DynamicOtConfig was used to dynamically load a tracer from a shared library |
There was a problem hiding this comment.
i think we probably want to make this not-implemented-hide
There was a problem hiding this comment.
We have provided file level hiding feature and we can hide this file completely. But by the way, why we don't remove this directly?
There was a problem hiding this comment.
i think it cant be removed as its part of the api, which is essentially immutable (or at least unremovable)
i dont think its hidden currently (or in this PR)
There was a problem hiding this comment.
But now any one use the API will only get an error? (Although I have no strong point to that.)
There was a problem hiding this comment.
i dont think its hidden currently (or in this PR)
Yeah. I mean we can hide this file completely. This is a optional suggestion to @alyssawilk
Updated that comment to make it more clear
Signed-off-by: Alyssa Wilk <[email protected]>
repokitteh-read-only
bot
added
api
deps
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
we can also remove the opentracing dep setup from bazel/repos - but lets do that in a follow up
lgtm, thanks @alyssawilk
repokitteh-read-only
bot
removed
the
deps
Risk Level: medium Testing: n/a Docs Changes: Release Notes: inline Fixes envoyproxy#27401 Fixes envoyproxy#34321 --------- Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: Martin Duke <[email protected]>
Risk Level: medium Testing: n/a Docs Changes: Release Notes: inline Fixes envoyproxy#27401 Fixes envoyproxy#34321 --------- Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: asingh-g <[email protected]>
5 participants
Risk Level: medium
Testing: n/a
Docs Changes:
Release Notes: inline
Fixes #27401
Fixes #34321