build: static linking for sanitizers#34306
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom May 29, 2024
Merged
Conversation
Signed-off-by: Alyssa Wilk <[email protected]>
Contributor
Author
|
hey OT folks: looks like we can simplify our ASAN/TSAN builds (and catch more errors) but the OT tests are failing with what looks like a legit upstream OT error: |
Contributor
Author
|
/retest |
Signed-off-by: Alyssa Wilk <[email protected]>
lizan
approved these changes
May 29, 2024
Member
lizan
left a comment
lizan
left a comment
There was a problem hiding this comment.
I don't quite remember what was the original reason for this, probably due to some build constraints (too big binary?) but if it works it should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this is slightly better as it catches things dynamic linking did not.
Risk Level: n/a (test only)
Testing: CI
Docs Changes: n/a
Release Notes: n/a