cluster manager: support dynamic add/remove#323
Merged
mattklein123 merged 4 commits intomasterfrom Jan 6, 2017
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all of the plumbing required to support the CDS API. I will do the
actual polling API in a follow up as this change is large enough as it is
(it's also missing stats and some debug logging which I will also do in a follow
up).
What this change does:
a unique_ptr and are inline destroyed on the main thread. Workers only have
access to the backing shared ClusterInfo.
in the relevant cluster destructors.
the cluster interface. Otherwise testing all of the required scenarios is
too complicated. With the refactor done it's much easier to test all of the
different scenarios. This required generalizing a few things about how we
were initializing SDS clusters.
A few notes about this implementation:
that there will be a period of fetching/HC for dynamic clusters depending on the
configuration.