Adds support for passing hits_addend to ratelimit grpc client#28939
Merged
yanavlasov merged 5 commits intoenvoyproxy:mainfrom Aug 15, 2023
Merged
Conversation
Signed-off-by: yleng <[email protected]>
Signed-off-by: yleng <[email protected]>
Signed-off-by: yleng <[email protected]>
Signed-off-by: yleng <[email protected]>
Contributor
|
/assign-from @envoyproxy/envoy-maintainers |
|
@envoyproxy/envoy-maintainers assignee is @adisuissa |
adisuissa
reviewed
Aug 10, 2023
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
Minor comment, but otherwise LGTM.
test/extensions/filters/common/ratelimit/ratelimit_impl_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: yleng <[email protected]>
Contributor
Author
|
@zuercher do you mind taking a look? Need one more approval |
Contributor
Author
|
Or @mattklein123 if you can have a look 😃 |
yanavlasov
approved these changes
Aug 15, 2023
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Aug 17, 2023
…envoyproxy#28939)" This reverts commit ee4a49b. Signed-off-by: Ryan Northey <[email protected]>
This was referenced Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Adds support for passing hits_addend to ratelimit grpc client for weighted ratelimit request.
Additional Description: Note: This only modifies the grpc client. The ratelimit filter's behavior remains unchanged in this PR.
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:] N/A. Added default argument to 0 so ratelimit filter's behavior will remain unchanged.
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]