Use flags for access log when injecting failures#287
Closed
rshriram wants to merge 2 commits intoenvoyproxy:flags_for_access_logfrom
Closed
Use flags for access log when injecting failures#287rshriram wants to merge 2 commits intoenvoyproxy:flags_for_access_logfrom
rshriram wants to merge 2 commits intoenvoyproxy:flags_for_access_logfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged with #274 and not with master.
Set response code for delay injection
Add unit tests to check both flags accordingly