Opentracing dynamic: Commit generated files to avoid cmake.#27400
Opentracing dynamic: Commit generated files to avoid cmake.#27400phlax merged 1 commit intoenvoyproxy:mainfrom
Conversation
|
Hi @Oberon00, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
bazel/io_opentracing_cpp.patch
Outdated
There was a problem hiding this comment.
These were copied from the output of envoys previous build to ensure they match (installing a host CMake and not executing in Docker for "bootstrapping", but this won't be required for using them now that they are here)
|
great @Oberon00 looks like this is passing CI - could you fix DCO please |
Signed-off-by: Christian Neumüller <[email protected]>
Oberon00
force-pushed
the
bugfix/ot_dyn_commit_generated
branch
from
912c386 to
959d859
Compare
repokitteh-read-only
bot
removed
the
deps
|
@Oberon00 ready for review ? |
…xy#27400) Signed-off-by: Christian Neumüller <[email protected]>
…xy#27400) Signed-off-by: Christian Neumüller <[email protected]> Signed-off-by: Ryan Eskin <[email protected]>
4 participants
Commit Message: Opentracing dynamic: Commit generated files to avoid cmake.
Additional Description: See related PRs, issues
Risk Level: Low
Testing: Covered by CI
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:] No
[Optional Fixes #Issue]: Related to #9958
[Optional Fixes commit #PR or SHA]: Potentially replaces #27244, #27246
[Optional Deprecated:] Needs to be considered in future for this OpenTracing dynamic component
[Optional API Considerations:] N/A