http: route level filter disabled support#27210
Merged
wbpcode merged 15 commits intoenvoyproxy:mainfrom Jun 12, 2023
Merged
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Member
Author
|
/wait |
Member
Author
|
/wait This implementation will add additional hash searching for every filter instance creation. If there are lots filters need to be skipped, then this overhead should acceptable. But for the one who use lots of filters but needn't route level filter disable function, maybe this overhead is a little heavy. |
Signed-off-by: wbpcode <[email protected]>
wbpcode
force-pushed
the
dev-route-filter-config-support
branch
from
14f2e02 to
48a6e05
Compare
wbpcode
changed the title
Signed-off-by: wbpcode <[email protected]>
Signed-off-by: wbpcode <[email protected]>
soulxu
reviewed
May 9, 2023
markdroth
reviewed
May 9, 2023
Contributor
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Member
Author
|
/wait #27263 |
Contributor
|
Looking forward to seeing this land. I think this is super-useful as a generic per-route filter opt-in/opt-out, which is needed by k8s Gateway https://gateway-api.sigs.k8s.io/api-types/httproute/#filters-optional. |
Member
Author
|
Waiting for #27263 to be land first. But i think we almost get there. 🙂 |
added 2 commits
June 4, 2023 03:20
Signed-off-by: wbpcode <[email protected]>
Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]>
Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]>
Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]>
Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]>
Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]>
Signed-off-by: wbpcode <[email protected]>
Member
Author
|
cc @mattklein123 |
mattklein123
previously approved these changes
Jun 8, 2023
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks, needs a main merge though.
Member
Author
|
cc @mattklein123 done, could you give a new stamp? thanks. |
mattklein123
approved these changes
Jun 12, 2023
asheryerm
pushed a commit
to asheryerm/envoy
that referenced
this pull request
Jul 5, 2023
* refactor and fix tests Signed-off-by: wbpcode <[email protected]> * fix test Signed-off-by: wbpcode <[email protected]> * more detailed comments Signed-off-by: wbpcode <[email protected]> * resolve conflict Signed-off-by: wbpcode <[email protected]> * fix test Signed-off-by: wbpcode <[email protected]> * change log and docs Signed-off-by: wbpcode <[email protected]> * Update changelogs/current.yaml Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * Update changelogs/current.yaml Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * Update changelogs/current.yaml Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * Update envoy/http/filter_factory.h Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * Update source/common/http/filter_chain_helper.cc Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * add new integration test Signed-off-by: wbpcode <[email protected]> --------- Signed-off-by: wbpcode <[email protected]> Signed-off-by: code <[email protected]> Co-authored-by: Matt Klein <[email protected]> Signed-off-by: asheryer <[email protected]>
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
* refactor and fix tests Signed-off-by: wbpcode <[email protected]> * fix test Signed-off-by: wbpcode <[email protected]> * more detailed comments Signed-off-by: wbpcode <[email protected]> * resolve conflict Signed-off-by: wbpcode <[email protected]> * fix test Signed-off-by: wbpcode <[email protected]> * change log and docs Signed-off-by: wbpcode <[email protected]> * Update changelogs/current.yaml Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * Update changelogs/current.yaml Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * Update changelogs/current.yaml Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * Update envoy/http/filter_factory.h Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * Update source/common/http/filter_chain_helper.cc Co-authored-by: Matt Klein <[email protected]> Signed-off-by: code <[email protected]> * add new integration test Signed-off-by: wbpcode <[email protected]> --------- Signed-off-by: wbpcode <[email protected]> Signed-off-by: code <[email protected]> Co-authored-by: Matt Klein <[email protected]> Signed-off-by: Ryan Eskin <[email protected]>
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: http: route level filter config support
Additional Description:
To close #15025, and implement of new API in the #25927. Partly related to #20867.
Specifically, is PR implement two features:
1. first, make the route/vh level per filter config could be optional. The old implementation has some problem and may need to be reverted.2. second, a common way to disable a filter by the route/vh level per filter config.
Risk Level: mid.
Testing: wait.
Docs Changes: wait.
Release Notes: wait.
Platform Specific Features: wait.