Revert "Optimize EDS stream allocation (#22419)"#25157
Merged
ggreenway merged 3 commits intoenvoyproxy:mainfrom Jan 26, 2023
Merged
Revert "Optimize EDS stream allocation (#22419)"#25157ggreenway merged 3 commits intoenvoyproxy:mainfrom
ggreenway merged 3 commits intoenvoyproxy:mainfrom
Conversation
This reverts commit 97a7f00. There was a crash reported by go-control-plane attributed to this change: envoyproxy/go-control-plane#625 Signed-off-by: Greg Greenway <[email protected]>
mattklein123
previously approved these changes
Jan 25, 2023
mattklein123
approved these changes
Jan 26, 2023
VishalDamgude
pushed a commit
to freshworks-oss/envoy
that referenced
this pull request
Feb 2, 2023
…y#25157) This reverts commit 97a7f00. There was a crash reported by go-control-plane attributed to this change: envoyproxy/go-control-plane#625 Signed-off-by: Greg Greenway <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 97a7f00.
There was a crash reported by go-control-plane attributed to this change: envoyproxy/go-control-plane#625
Signed-off-by: Greg Greenway [email protected]
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]