build: removing forced cares and apple dns deps#23917
Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom Nov 10, 2022
Merged
build: removing forced cares and apple dns deps#23917alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <[email protected]>
Contributor
Author
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Alyssa Wilk <[email protected]>
Contributor
Author
|
@snowp I'm inclined to merge over the codeQL failure, so this is ready for review. |
lizan
approved these changes
Nov 10, 2022
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Nov 16, 2022
1. Update ENVOY_COMMIT to [23917](envoyproxy/envoy#23917) 3. Update the way of initiating ClusterManagerFactory object in source/client/process_impl.cc due to envoy commit [23917](envoyproxy/envoy#23917) 4. Include cares, static and strict_dns in extensions_build_config.bzl due to envoy commit [23890](envoyproxy/envoy#23890) Signed-off-by: fei-deng <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making clusters lazily create DNS resolvers so Envoys with, say, only static clusters don't need any DNS dependency.
Risk Level: medium
Testing: n/a
Docs Changes: n/a
Release Notes: inline
Part of envoyproxy/envoy-mobile#2629