Conversation
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Keith Smiley <[email protected]>
keith
force-pushed
the
ks/bazel-update-to-6.0.0rc1
branch
from
3e17981 to
4cbce1a
Compare
ci/windows_ci_steps.sh
Outdated
| # Complete envoy-static build | ||
| if [[ $BUILD_ENVOY_STATIC -eq 1 ]]; then | ||
| bazel "${BAZEL_STARTUP_OPTIONS[@]}" build "${BAZEL_BUILD_OPTIONS[@]}" //source/exe:envoy-static | ||
| bazel "${BAZEL_STARTUP_OPTIONS[@]}" build --output_groups=+pdb_file "${BAZEL_BUILD_OPTIONS[@]}" //source/exe:envoy-static |
There was a problem hiding this comment.
New requirement to force bazel to download this when using remote exec
There was a problem hiding this comment.
i dont entirely understand why this is now required here but wondering if we need to add it anywhere else and/or update relevant docs
There was a problem hiding this comment.
I moved it to the .bazelrc instead, which should eliminate the need for that for folks not using the scripts. the gist of it is that previously building cc_binary targets would always output the binary and the pdb file, now you have to explicitly request the pdb file, realistically I think this only applies to remote exec, which otherwise skips the download of it.
Signed-off-by: Keith Smiley <[email protected]>
repokitteh-read-only
bot
removed
the
deps
| project_url = "https://github.com/bazelbuild/rules_license", | ||
| version = "0.0.3", | ||
| sha256 = "00ccc0df21312c127ac4b12880ab0f9a26c1cff99442dc6c5a331750360de3c3", | ||
| urls = ["https://github.com/bazelbuild/rules_license/releases/download/0.0.3/rules_license-0.0.3.tar.gz"], |
There was a problem hiding this comment.
I didn't see this one come through - we shouldn't hard code the versions here. Should be
urls = ["https://github.com/bazelbuild/rules_license/releases/download/{version}/rules_license-{version}.tar.gz"],
This reverts commit 84df237. Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
3 participants
No description provided.