Skip to content

Comments

test: moving echo test#18938

Merged
htuch merged 2 commits intoenvoyproxy:mainfrom
alyssawilk:echo
Nov 9, 2021
Merged

test: moving echo test#18938
htuch merged 2 commits intoenvoyproxy:mainfrom
alyssawilk:echo

Conversation

@alyssawilk
Copy link
Contributor

I did a pass at trying to move all tests using the echo filter to something else, and decided that echo filter is a reasonable filter to use for testing. We could copy paste a clone into test if we want pure separation for #9953 but I'm inclined to just remove the TODO.

Risk Level: n/a (test only)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Part of #9953

Signed-off-by: Alyssa Wilk <[email protected]>
@alyssawilk alyssawilk requested a review from htuch as a code owner November 8, 2021 21:43
@alyssawilk alyssawilk changed the title test: moving echo testb test: moving echo test Nov 8, 2021
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 47ebcd5 into envoyproxy:main Nov 9, 2021
mpuncel added a commit to mpuncel/envoy that referenced this pull request Nov 10, 2021
* main: (71 commits)
  bazel: fix macOS build (envoyproxy#18920)
  http: switching from 100 to 1xx (envoyproxy#18904)
  grpc: implement BufferedAsyncClient for bidirectional gRPC stream (envoyproxy#18129)
  bazel: add repository arg to benchmark_test (envoyproxy#18795)
  rocketmq_proxy: Improvement for map find (envoyproxy#18909)
  tls: unit test: spiffe signed by intermediate cert (envoyproxy#18914)
  Test for FilterConfigPerRoute dtor called on worker thread. (envoyproxy#18927)
  deps: Bump `com_google_protobuf` -> 3.19.1 (envoyproxy#18930)
  deps: Bump `com_googlesource_code_re2` -> 2021-11-01 (envoyproxy#18933)
  cvescan: Move cvescan data to yaml (envoyproxy#18947)
  remove unnecessary file level not unimplemented hide annotation (envoyproxy#18924)
  test: moving echo test (envoyproxy#18938)
  test: fixing a test flake (envoyproxy#18899)
  deps: Revert pyparsing bump (envoyproxy#18946)
  deps: Bump `build_bazel_rules_apple` -> 0.32.0 (envoyproxy#18932)
  deps: Bump `com_github_bazelbuild_buildtools` -> 4.2.3 (envoyproxy#18931)
  build(deps): bump pycparser from 2.20 to 2.21 in /tools/dependency (envoyproxy#18936)
  quic: supporting connections with zero initial available streams (envoyproxy#18775)
  test: moving proxy proto (envoyproxy#18939)
  build(deps): bump pyparsing from 3.0.4 to 3.0.5 in /tools/dependency (envoyproxy#18937)
  ...

Signed-off-by: Michael Puncel <[email protected]>
@alyssawilk alyssawilk deleted the echo branch August 4, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants