tls: unit test: spiffe signed by intermediate cert#18914
Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom Nov 10, 2021
Merged
tls: unit test: spiffe signed by intermediate cert#18914yanavlasov merged 1 commit intoenvoyproxy:mainfrom
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
Conversation
luksa
requested review from
asraa,
ggreenway,
lizan and
mathetake
as code owners
|
Hi @luksa, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
luksa
force-pushed
the
tls-spiffe-signed-by-intermediate
branch
2 times, most recently
from
fe78f6c to
673f594
Compare
mathetake
reviewed
Nov 8, 2021
Member
mathetake
left a comment
mathetake
left a comment
There was a problem hiding this comment.
Thanks, the code looks good to me. Could you fix the format?
/wait
luksa
force-pushed
the
tls-spiffe-signed-by-intermediate
branch
from
673f594 to
54ff7d7
Compare
luksa
force-pushed
the
tls-spiffe-signed-by-intermediate
branch
from
54ff7d7 to
fed88d6
Compare
Signed-off-by: Marko Lukša <[email protected]>
luksa
force-pushed
the
tls-spiffe-signed-by-intermediate
branch
from
fed88d6 to
b59a667
Compare
mathetake
approved these changes
Nov 8, 2021
oschaaf
approved these changes
Nov 9, 2021
yanavlasov
approved these changes
Nov 10, 2021
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Nov 10, 2021
* main: (71 commits) bazel: fix macOS build (envoyproxy#18920) http: switching from 100 to 1xx (envoyproxy#18904) grpc: implement BufferedAsyncClient for bidirectional gRPC stream (envoyproxy#18129) bazel: add repository arg to benchmark_test (envoyproxy#18795) rocketmq_proxy: Improvement for map find (envoyproxy#18909) tls: unit test: spiffe signed by intermediate cert (envoyproxy#18914) Test for FilterConfigPerRoute dtor called on worker thread. (envoyproxy#18927) deps: Bump `com_google_protobuf` -> 3.19.1 (envoyproxy#18930) deps: Bump `com_googlesource_code_re2` -> 2021-11-01 (envoyproxy#18933) cvescan: Move cvescan data to yaml (envoyproxy#18947) remove unnecessary file level not unimplemented hide annotation (envoyproxy#18924) test: moving echo test (envoyproxy#18938) test: fixing a test flake (envoyproxy#18899) deps: Revert pyparsing bump (envoyproxy#18946) deps: Bump `build_bazel_rules_apple` -> 0.32.0 (envoyproxy#18932) deps: Bump `com_github_bazelbuild_buildtools` -> 4.2.3 (envoyproxy#18931) build(deps): bump pycparser from 2.20 to 2.21 in /tools/dependency (envoyproxy#18936) quic: supporting connections with zero initial available streams (envoyproxy#18775) test: moving proxy proto (envoyproxy#18939) build(deps): bump pyparsing from 3.0.4 to 3.0.5 in /tools/dependency (envoyproxy#18937) ... Signed-off-by: Michael Puncel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: tls: unit test: spiffe signed by intermediate cert
Additional Description: Adds a unit test for SPIFFE cert verification where the leaf cert is signed by the intermediate instead of the root CA. This is a real-world scenario that previously had no unit test.
Risk Level: low
Testing: added unit test only
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a