Fix Apple & c-ares DNS Resolver Factories#18690
Fix Apple & c-ares DNS Resolver Factories#18690mattklein123 merged 1 commit intoenvoyproxy:mainfrom jpsim:fix-dns-factories
Conversation
By convention these don't have an "Impl" suffix Signed-off-by: JP Simard <[email protected]>
Signed-off-by: JP Simard <[email protected]>
|
macos test failure appears unrelated:
|
mattklein123
left a comment
There was a problem hiding this comment.
Sorry why is this change needed?
/wait-any
These factories were registered with the suffix "Impl" but declared without the suffix:
This was my mistake when adding the declarations in #18646, since I went based off of the convention of other factories being declared without the "Impl" suffix and didn't notice that the registration was using a different name. This manifested as a linker error when attempting to link anything using the extension because that symbol wasn't being emitted in the binary: |
|
Ah OK got it, thanks. LGTM. |
Commit Message: Fix Apple & c-ares DNS Resolver Factories
Additional Description: By convention these don't have an "Impl" suffix
Risk Level: Low. Since the factory registration wasn't correct, no downstream consumers have already integrated this successfully.
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]