[dns] Declare AppleDnsResolverFactory#18646
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Oct 18, 2021
jpsim:apple_dns_declare_factory
Merged
[dns] Declare AppleDnsResolverFactory#18646mattklein123 merged 2 commits intoenvoyproxy:mainfrom jpsim:apple_dns_declare_factory
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
jpsim:apple_dns_declare_factory
Conversation
Followup to #17479 Signed-off-by: JP Simard <[email protected]>
|
Hi @jpsim, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
mattklein123
requested changes
Oct 16, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thanks for adding this. Can you also add one for c-ares since we will need that for Android? Also please check format.
/wait
Signed-off-by: JP Simard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17479
This is so platforms where Envoy is statically linked (e.g. iOS) can prevent the linker from stripping out extensions.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]