Skip to content

LEDS: adding docs#18429

Closed
adisuissa wants to merge 4 commits intoenvoyproxy:mainfrom
adisuissa:envoy_leds_docs
Closed

LEDS: adding docs#18429
adisuissa wants to merge 4 commits intoenvoyproxy:mainfrom
adisuissa:envoy_leds_docs

Conversation

@adisuissa
Copy link
Contributor

Commit Message: LEDS: adding docs
Additional Description: Followup of #18195, adding the release note and the general docs regarding the new LEDS API.
Risk Level: N/A - docs only.
Testing: N/A - docs only.
Docs Changes: Updated general docs with the new LEDS API.
Release Notes: Added to release notes.
Platform Specific Features: N/A.

Signed-off-by: Adi Suissa-Peleg [email protected]

Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just wondering if some docs or something in examples/ added to show how this can be used.


.. _arch_overview_endpoint_discovery_types_leds:

Locality-Endpoint discovery service (LEDS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any docs on how to configure LEDS?

Locality-Endpoint discovery service (LEDS)
""""""""""""""""""""""""""""""""""""""""""

The *locality-endpoint discovery service* is a :ref:`xDS management server based on gRPC in incremental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: is this a discovery service for locality endpoints, or the endpoint discovery service for localities? :)

@htuch
Copy link
Member

htuch commented Oct 11, 2021

/wait

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 10, 2021
@htuch
Copy link
Member

htuch commented Nov 11, 2021

@adisuissa what's the status of this PR?

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Nov 11, 2021
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 11, 2021
@htuch
Copy link
Member

htuch commented Dec 12, 2021

@adisuissa what's left to wrap this one?

@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Dec 12, 2021
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 12, 2022
@github-actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants