Conversation
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
@adisuissa thanks. Can we go over this PR at our sync tomorrow? I think I'd benefit from a guided tour given the size. |
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Overall looks good and excited to see LEDS almost there! A few implementation comments to start with, mostly about missing coverage / refactoring.
/wait
| // Called upon an update to the locality. | ||
| if (validateAllLedsUpdated()) { | ||
| BatchUpdateHelper helper(*this); | ||
| priority_set_.batchHostUpdate(helper); |
There was a problem hiding this comment.
Is the invariant that this is called only once per update and for the last LEDS subscription to update?
There was a problem hiding this comment.
It is called once per LEDS update, and should cover the following cases:
- Before all the locality endpoints of a specific EDS cluster are ready (this will fail the
validateAllLedsUpdated()call, and no actual update will occur. - Whenever a new update for some locality arrives.
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Looks good! Just some minor comments.
/wait
Signed-off-by: Adi Suissa-Peleg <[email protected]>
Signed-off-by: Adi Suissa-Peleg <[email protected]>
|
@htuch thanks for the comments. Should be ready for another pass. |
|
FWIW I chatted with Adi offline and the plan is to land docs / release notes in a followup PR. |
2 participants
Commit Message: LEDS: integrating with EDS
Additional Description:
Allows the usage of the LEDS protocol with EDS messages.
Most of the changes are for the integration tests.
One key question is whether we can minimize the amount of memory used when LEDS isn't used.
Risk Level: Medium - Impact EDS behavior.
Testing: Many integration tests.
Docs Changes: TBD.
Release Notes: TBD.
Platform Specific Features: N/A.
Signed-off-by: Adi Suissa-Peleg [email protected]