Skip to content

Fix debug build.#181

Merged
mattklein123 merged 1 commit intomasterfrom
fix_build
Oct 31, 2016
Merged

Fix debug build.#181
mattklein123 merged 1 commit intomasterfrom
fix_build

Conversation

@RomanDzhabarov
Copy link
Copy Markdown
Member

No description provided.

@mattklein123 mattklein123 merged commit 6bb5998 into master Oct 31, 2016
@mattklein123 mattklein123 deleted the fix_build branch October 31, 2016 23:23
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this pull request Oct 10, 2019
PiotrSikora added a commit to PiotrSikora/envoy that referenced this pull request Mar 4, 2020
This is similar to the http2 frame protection, but rather than try to
guard
[header block || last body bytes || last chunk in chunk encoding ||
trailer block]
depending on end stream, which just gets messy, I opted to just add an
empty reference counted fragment after the body was serialized, which
appears to work just as well with a small theoretical overhead.  If
folks think the complexity is warranted I can of course do that instead.

Risk Level: Medium
Testing: new unit tests, integration test
Docs Changes: stats documented
Release Notes: added

Signed-off-by: Alyssa Wilk <[email protected]>

Co-authored-by: Lizan Zhou <[email protected]>
PiotrSikora added a commit that referenced this pull request Jun 30, 2020
PiotrSikora added a commit that referenced this pull request Jun 30, 2020
PiotrSikora pushed a commit that referenced this pull request Jun 30, 2020
aimless404 pushed a commit to aimless404/envoy that referenced this pull request Jun 30, 2020
liuxu623 pushed a commit to liuxu623/envoy that referenced this pull request Jul 14, 2020
wolfguoliang pushed a commit to wolfguoliang/envoy that referenced this pull request Jan 23, 2021
…nfiguration

zh-translation: docs/root/intro/arch_overview/operations/dynamic_conf…
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Jose Nino [email protected]

Description: This PR concludes binary size investigation slated for issue #17. The three deliverables of this PR are:

1. Developer documentation that solidifies the building and analysis platform used for binary size analysis.
2. A list of issues for next steps in binary size reduction under the perf/size label.
3. A final baseline size for the binary:

As of https://github.com/lyft/envoy-mobile/tree/11530fe10212778d811657823f3fde23425cdd28
The test_binary_size_size as built by the toolchain against the architecture described (arm64 with clang and lld)
compiles to a stripped size of 8.9mb and a compressed size of 3mb.

Additionally #181 will add CI jobs to add size regression analysis on every PR.

Risk Level: low - add new bazel target and docs.
Docs Changes: added developer documentation.
Fixes #17

Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Jose Nino [email protected]

Description: after #173 landed this target broke due to the breaking API change. This target will be added to CI once #181 closes, so breakages like this will not go undected.
Risk Level: low - updating API, deleting old build rules.

Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Jose Nino [email protected]

Description: This PR concludes binary size investigation slated for issue #17. The three deliverables of this PR are:

1. Developer documentation that solidifies the building and analysis platform used for binary size analysis.
2. A list of issues for next steps in binary size reduction under the perf/size label.
3. A final baseline size for the binary:

As of https://github.com/lyft/envoy-mobile/tree/11530fe10212778d811657823f3fde23425cdd28
The test_binary_size_size as built by the toolchain against the architecture described (arm64 with clang and lld)
compiles to a stripped size of 8.9mb and a compressed size of 3mb.

Additionally #181 will add CI jobs to add size regression analysis on every PR.

Risk Level: low - add new bazel target and docs.
Docs Changes: added developer documentation.
Fixes #17

Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Jose Nino [email protected]

Description: after #173 landed this target broke due to the breaking API change. This target will be added to CI once #181 closes, so breakages like this will not go undected.
Risk Level: low - updating API, deleting old build rules.

Signed-off-by: JP Simard <[email protected]>
mathetake added a commit that referenced this pull request Mar 3, 2026
**Commit Message**:

This CONTRIBUTING.md by adding some of the
missing dependencies.

**Related Issues/PRs (if applicable)**:

Follow up on #180

Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants