Skip to content

xds: Clarify spec of incremental protocol unsubscribe behavior#17983

Merged
zuercher merged 1 commit intoenvoyproxy:mainfrom
markdroth:xds_incremental_wildcard_handling
Sep 8, 2021
Merged

xds: Clarify spec of incremental protocol unsubscribe behavior#17983
zuercher merged 1 commit intoenvoyproxy:mainfrom
markdroth:xds_incremental_wildcard_handling

Conversation

@markdroth
Copy link
Copy Markdown
Contributor

Signed-off-by: Mark D. Roth [email protected]

Commit Message: xds: Clarify spec of incremental protocol unsubscribe behavior
Additional Description: Clarify server and client behavior.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A

CC @htuch @krnowak

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@htuch
Copy link
Copy Markdown
Member

htuch commented Sep 5, 2021

CC @krnowak @envoyproxy/api-shepherds in case there are any comments before merging.

Copy link
Copy Markdown
Contributor

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuercher zuercher merged commit 4a28741 into envoyproxy:main Sep 8, 2021
@markdroth markdroth deleted the xds_incremental_wildcard_handling branch September 8, 2021 19:09
tyxia pushed a commit to tyxia/envoy that referenced this pull request Sep 21, 2021
…proxy#17983)

Clarify server and client behavior.

Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Mark D. Roth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants