mac-ci: add a CI workflow for Mac OS builds#1748
Merged
mattklein123 merged 6 commits intoenvoyproxy:masterfrom Sep 27, 2017
Merged
mac-ci: add a CI workflow for Mac OS builds#1748mattklein123 merged 6 commits intoenvoyproxy:masterfrom
mattklein123 merged 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Stephan Zuercher <[email protected]>
Signed-off-by: Stephan Zuercher <[email protected]>
Signed-off-by: Stephan Zuercher <[email protected]>
Signed-off-by: Stephan Zuercher <[email protected]>
Signed-off-by: Stephan Zuercher <[email protected]>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
LGTM. Go with this or do you want to add back caching?
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Sorry just caught a typo. Otherwise LGTM.
ci/README.md
Outdated
| The MacOS CI build is part of the [CircleCI](https://circleci.com/gh/envoyproxy/envoy) workflow. | ||
| Dependencies are installed by the `ci/mac_ci_setup.sh` script, via [Homebrew](https://brew.sh), | ||
| which is pre-installed on the CircleCI MacOS image. The dependencies are cached are re-installed | ||
| n every build. The `ci/mac_ci_steps.sh` script executes the specific commands that |
Signed-off-by: Stephan Zuercher <[email protected]>
mattklein123
approved these changes
Sep 26, 2017
costinm
pushed a commit
to costinm/envoy
that referenced
this pull request
Oct 2, 2017
Signed-off-by: Stephan Zuercher <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This will reduce the change surface required when (if ever) changing the json lib dep --------- Signed-off-by: Takeshi Yoneda <[email protected]> Co-authored-by: Aaron Choo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This configures Mac OS builds for envoy directly in the envoyproxy Circle CI account.
Per Circle CI this functionality should be enabled on that account.