Skip to content

apple dns: remove sharing UDS to local DNS daemon #17226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 7 commits into from
Jul 10, 2021
Merged

apple dns: remove sharing UDS to local DNS daemon #17226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a9065e3
apple dns: remove sharing UDS to local DNS daemon
Jul 2, 2021
5177b5b
clean
Jul 2, 2021
4394a40
release notes
Jul 2, 2021
862dde0
fmt
Jul 3, 2021
16333b0
more comments and tests on kDNSServiceFlagsAdd
Jul 9, 2021
1010e14
Merge branch 'main' into apple-dns-simple
Jul 9, 2021
11d579a
spelling
Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/root/version_history/current.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ Minor Behavior Changes
be now be disabled in favor of using unsigned payloads with compatible services via the new
``use_unsigned_payload`` filter option (default false).
* cluster: added default value of 5 seconds for :ref:`connect_timeout <envoy_v3_api_field_config.cluster.v3.Cluster.connect_timeout>`.
* dns: changed apple resolver implementation to not reuse the UDS to the local DNS daemon.
* dns cache: the new :ref:`dns_query_timeout <envoy_v3_api_field_extensions.common.dynamic_forward_proxy.v3.DnsCacheConfig.dns_query_timeout>` option has a default of 5s. See below for more information.
* http: disable the integration between :ref:`ExtensionWithMatcher <envoy_v3_api_msg_extensions.common.matching.v3.ExtensionWithMatcher>`
and HTTP filters by default to reflects its experimental status. This feature can be enabled by seting
Expand Down
3 changes: 1 addition & 2 deletions source/common/event/dispatcher_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,7 @@ Network::DnsResolverSharedPtr DispatcherImpl::createDnsResolver(
"using TCP for DNS lookups is not possible when using Apple APIs for DNS "
"resolution. Apple' API only uses UDP for DNS resolution. Use UDP or disable "
"the envoy.restart_features.use_apple_api_for_dns_lookups runtime feature.");
return std::make_shared<Network::AppleDnsResolverImpl>(*this, api_.randomGenerator(),
api_.rootScope());
return std::make_shared<Network::AppleDnsResolverImpl>(*this, api_.rootScope());
}
#endif
return std::make_shared<Network::DnsResolverImpl>(*this, resolvers, dns_resolver_options);
Expand Down
Loading