Conversation
mattklein123
force-pushed
the
circle_ci_actual
branch
9 times, most recently
from
febd83d to
6f5d7f0
Compare
Signed-off-by: Matt Klein <[email protected]>
mattklein123
force-pushed
the
circle_ci_actual
branch
from
6f5d7f0 to
1f5931e
Compare
|
Note CircleCI doesn't appear to support IPv6, otherwise this is mostly working other than the push portions. |
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
SGTM, when we have IPv6 this is a good-to-go AFAICT.
ci/do_circle_ci.sh
Outdated
| mv ~/.gitconfig ~/.gitconfig_save | ||
|
|
||
| export ENVOY_SRCDIR="$(pwd)" | ||
| export NUM_CPUS=8 # xlarge resource_class |
There was a problem hiding this comment.
Nit: why not let this be dynamically discovered to make it more robust?
There was a problem hiding this comment.
See the note here: https://circleci.com/docs/2.0/configuration-reference/#resource_class (It relates to how docker works unfortunately). I will add a comment here and generally clean this review up if we get IPv6 support.
There was a problem hiding this comment.
As @alyssawilk suggests on other threads, if we want to keep Travis around for just some IPv6 stuff, then we don't need to block the Circle CI move.
ci/do_circle_ci.sh
Outdated
|
|
||
| export ENVOY_SRCDIR="$(pwd)" | ||
| export NUM_CPUS=8 # xlarge resource_class | ||
| ci/do_ci.sh $1 |
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]>
|
@htuch updated |
|
Actually let me add the build_images job also to this PR. |
Signed-off-by: Matt Klein <[email protected]>
|
I don't see the Travis run in the above checks.. |
|
See continuous-integration/travis-ci/pr it's running. |
Description: This fixes up #1617. The "DirectResponse" test mechanism is super brittle and sensitive to indentation changes. I very much want to go and clean it up once config phase 3 ships, since that will provide a saner path. Risk Level: Moderate Testing: CI & Local Co-authored-by: alyssawilk <[email protected]> Signed-off-by: Mike Schore <[email protected]> Signed-off-by: JP Simard <[email protected]>
Description: This fixes up #1617. The "DirectResponse" test mechanism is super brittle and sensitive to indentation changes. I very much want to go and clean it up once config phase 3 ships, since that will provide a saner path. Risk Level: Moderate Testing: CI & Local Co-authored-by: alyssawilk <[email protected]> Signed-off-by: Mike Schore <[email protected]> Signed-off-by: JP Simard <[email protected]>
**Description** Add Bloomberg engineering logo and Bloomberg open source url link. --------- Signed-off-by: Dan Sun <[email protected]>
2 participants
This commit gives us basic IPv4 support via CircleCI. We still test IPv6 on
Travis as Circle does not yet support IPv4. This commit is going to fail the
master pushes. I need to make new keys and creds and configure env vars
in Circle. I would like to ship this and then I will work on that.
Signed-off-by: Matt Klein [email protected]