Skip to content

cluster_manager: fix use-after-free bug in drainConnPools(). #1636

Merged
htuch merged 2 commits intoenvoyproxy:masterfrom
htuch:drain-conn-pools
Sep 14, 2017
Merged

cluster_manager: fix use-after-free bug in drainConnPools(). #1636
htuch merged 2 commits intoenvoyproxy:masterfrom
htuch:drain-conn-pools

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Sep 13, 2017

This showed up in the ASAN/TSAN presubmits for #1621.

Bonus namespace cleanup in rds_subscription.cc that I hit with local clang-asan run.

This showed up in the ASAN/TSAN presubmits for envoyproxy#1621.

Bonus namespace cleanup in rds_subscription.cc that I hit with local clang-asan run.
@htuch htuch changed the title Drain conn pools cluster_manager: fix use-after-free bug in drainConnPools(). Sep 13, 2017
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@htuch htuch merged commit a6f3c58 into envoyproxy:master Sep 14, 2017
@htuch htuch deleted the drain-conn-pools branch September 14, 2017 13:49
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: Add method for enabling Envoy admin interface.
Risk Level: Low (new feature, disabled by default)
Testing: Unit, Manual
Docs Changes: Added
Release Notes: None

Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: Add method for enabling Envoy admin interface.
Risk Level: Low (new feature, disabled by default)
Testing: Unit, Manual
Docs Changes: Added
Release Notes: None

Signed-off-by: Rafal Augustyniak <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants