add xxHash64 wrapper and convert most hashing#1627
Merged
danielhochman merged 2 commits intomasterfrom Sep 12, 2017
Merged
Conversation
| class HashUtil { | ||
| public: | ||
| /** | ||
| * Return 64-bit hash with seed of 0 from the xxHash algorithm. |
Member
There was a problem hiding this comment.
nit: Can you link to repo/docs so people can read about it if they want.
source/common/redis/conn_pool_impl.h
Outdated
| struct LbContextImpl : public Upstream::LoadBalancerContext { | ||
| LbContextImpl(const std::string& hash_key) : hash_key_(std::hash<std::string>()(hash_key)) {} | ||
|
|
||
| // TODO(danielhochman): convert to HashUtil::xxHash64 when we have a migration strategy |
Member
There was a problem hiding this comment.
nit: period end of sentence
| for (const auto& host : hosts) { | ||
| for (uint64_t i = 0; i < hashes_per_host; i++) { | ||
| std::string hash_key(host->address()->asString() + "_" + std::to_string(i)); | ||
| // TODO(danielhochman): convert to HashUtil::xxHash64 when we have a migration strategy |
Member
There was a problem hiding this comment.
nit: period end of sentence
mattklein123
approved these changes
Sep 12, 2017
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** Users are advised to use `aigw-admin` port name for aggregating metrics as per the example: https://github.com/envoyproxy/ai-gateway/blob/main/examples/monitoring/monitoring.yaml Signed-off-by: Takeshi Yoneda <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup to #1624
left hashing in redis path alone for now. will figure out an internal strategy for migrating, possibly compiling in what std::hash is using so we don't have to worry about rehashing all of our cache data on deploy.
fixes #1452