Merged
Conversation
added 2 commits
September 11, 2017 15:27
mattklein123
approved these changes
Sep 12, 2017
Member
|
@danielhochman is this hash going to be strong enough to resolve #1452? |
Contributor
Author
|
@htuch yeah, it should be strong enough. we largely used https://github.com/rurban/smhasher to evaluate different options. smhasher assigns a quality score based on collision probability, etc for which xxhash earned a 10. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we use
std::hashfor hashing which is not consistent across platforms. This introduces xxHash which is portable, fast, and used by many other open-source projects.After this PR is merged, I will followup with a change to update
ENVOY_BUILD_SHAand convert usages ofstd::hash.