transport_sockets: removed well_known_names.h file by daixiang0 · Pull Request #16164 · envoyproxy/envoy

daixiang0 · 2021-04-26T07:44:53Z

Commit Message:
Removed transport_sockets/well_known_names.h file.

Risk Level: Low
Testing: Make sure that all unit and integration tests pass
Docs Changes: No
Release Notes: No
Platform Specific Features:
Partially fixes: #7238

repokitteh-read-only · 2021-04-26T07:44:57Z

Hi @daixiang0, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #16164 was opened by daixiang0.

see: more, trace.

yanavlasov · 2021-04-27T19:51:29Z

Thanks for making this change.
I think you have missed a reference in source/common/quic/BUILD line 266

yanavlasov · 2021-04-27T19:51:34Z

/wait

yanavlasov · 2021-04-28T15:52:23Z

Looks like QUIC test is failing: https://dev.azure.com/cncf/envoy/_build/results?buildId=73616&view=logs&j=8c169225-0ae8-53bd-947f-07cb81846cb5&t=6b0ace90-28b2-51d9-2951-b1fd35e67dec&l=19985

daixiang0 · 2021-04-29T00:35:00Z

I am looking at it.

daixiang0 · 2021-04-29T04:48:03Z

/retest

repokitteh-read-only · 2021-04-29T04:48:07Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16164 (comment) was created by @daixiang0.

see: more, trace.

daixiang0 · 2021-04-29T06:18:32Z

@yanavlasov now all tests pass.

daixiang0 · 2021-04-29T06:26:11Z

@mattbailey hi, please help review.

yanavlasov · 2021-04-29T23:58:43Z

Ugh, looks like the game of merge whack-a-mole on this large PR. Please ping me on slack when you fix conflicts so I can merge it as soon as possible to avoid getting merge conflicts.

yanavlasov · 2021-04-29T23:58:51Z

/wait

daixiang0 · 2021-04-30T02:02:19Z

/retest

repokitteh-read-only · 2021-04-30T02:02:22Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16164 (comment) was created by @daixiang0.

see: more, trace.

yanavlasov · 2021-05-03T18:31:53Z

I think there are still includes of well_known_names.h in the quic code.

/wait

yanavlasov · 2021-05-06T17:02:27Z

/wait

daixiang0 · 2021-05-08T06:28:01Z

/retest

repokitteh-read-only · 2021-05-08T06:28:07Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16164 (comment) was created by @daixiang0.

see: more, trace.

daixiang0 · 2021-05-10T01:17:08Z

re-push to re-run test.

Signed-off-by: Long Dai <[email protected]>

daixiang0 · 2021-05-11T05:18:38Z

@yanavlasov seems windows test flasky :(

daixiang0 requested review from alyssawilk, antoniovicente, asraa, cpakulski, ggreenway and lizan as code owners April 26, 2021 07:44

repokitteh-read-only bot added the waiting label Apr 27, 2021

daixiang0 force-pushed the ts_well_known_names branch from 28fea75 to 36c9a7c Compare April 28, 2021 01:20

repokitteh-read-only bot removed the waiting label Apr 28, 2021

daixiang0 force-pushed the ts_well_known_names branch from ca5bf17 to 70bd74b Compare April 28, 2021 08:31

daixiang0 force-pushed the ts_well_known_names branch 2 times, most recently from c92ffd0 to 7817fd0 Compare April 29, 2021 04:10

repokitteh-read-only bot added the waiting label Apr 29, 2021

daixiang0 force-pushed the ts_well_known_names branch from 7817fd0 to 1e8b93c Compare April 30, 2021 01:16

repokitteh-read-only bot removed the waiting label Apr 30, 2021

daixiang0 force-pushed the ts_well_known_names branch from 10f9ab0 to 67a04c8 Compare April 30, 2021 02:43

ggreenway assigned yanavlasov May 3, 2021

repokitteh-read-only bot added the waiting label May 3, 2021

daixiang0 force-pushed the ts_well_known_names branch from 67a04c8 to dc7b7ea Compare May 6, 2021 07:25

repokitteh-read-only bot removed the waiting label May 6, 2021

daixiang0 force-pushed the ts_well_known_names branch from dc7b7ea to fef3cd4 Compare May 6, 2021 08:29

repokitteh-read-only bot added the waiting label May 6, 2021

daixiang0 force-pushed the ts_well_known_names branch from fef3cd4 to 6bc8d3b Compare May 8, 2021 04:21

repokitteh-read-only bot removed the waiting label May 8, 2021

daixiang0 force-pushed the ts_well_known_names branch from 6bc8d3b to 92ac44e Compare May 10, 2021 01:16

daixiang0 force-pushed the ts_well_known_names branch from 92ac44e to bea9b6c Compare May 11, 2021 02:09

transport_sockets: removed well_known_names.h file

52499a1

Signed-off-by: Long Dai <[email protected]>

daixiang0 force-pushed the ts_well_known_names branch from bea9b6c to 52499a1 Compare May 11, 2021 02:12

yanavlasov approved these changes May 14, 2021

View reviewed changes

yanavlasov merged commit 874fb03 into envoyproxy:main May 14, 2021

daixiang0 deleted the ts_well_known_names branch May 14, 2021 02:26

Conversation

daixiang0 commented Apr 26, 2021

Uh oh!

repokitteh-read-only bot commented Apr 26, 2021

Uh oh!

yanavlasov commented Apr 27, 2021

Uh oh!

yanavlasov commented Apr 27, 2021

Uh oh!

yanavlasov commented Apr 28, 2021

Uh oh!

daixiang0 commented Apr 29, 2021

Uh oh!

daixiang0 commented Apr 29, 2021

Uh oh!

repokitteh-read-only bot commented Apr 29, 2021

Uh oh!

daixiang0 commented Apr 29, 2021

Uh oh!

daixiang0 commented Apr 29, 2021

Uh oh!

yanavlasov commented Apr 29, 2021

Uh oh!

yanavlasov commented Apr 29, 2021

Uh oh!

daixiang0 commented Apr 30, 2021

Uh oh!

repokitteh-read-only bot commented Apr 30, 2021

Uh oh!

yanavlasov commented May 3, 2021

Uh oh!

yanavlasov commented May 6, 2021

Uh oh!

daixiang0 commented May 8, 2021

Uh oh!

repokitteh-read-only bot commented May 8, 2021

Uh oh!

daixiang0 commented May 10, 2021

Uh oh!

daixiang0 commented May 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants