Directly depend on fmtlib for fmt::format#1582
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 1, 2017
Merged
Directly depend on fmtlib for fmt::format#1582mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-updated build SHA to incorporate spdlog update
-include fmtlib directly in files where spdlog was included in order to use fmt::format, and remove the spdlog include
-edit associated BUILD files to add fmtlib as an external_dep
#975