dns cache: return host info in in-cache case of loadDnsCacheEntry#15498
Merged
snowp merged 2 commits intoenvoyproxy:mainfrom Mar 17, 2021
Merged
dns cache: return host info in in-cache case of loadDnsCacheEntry#15498snowp merged 2 commits intoenvoyproxy:mainfrom
loadDnsCacheEntry#15498snowp merged 2 commits intoenvoyproxy:mainfrom
Conversation
This is a follow-up to envoyproxy#15144 that returns the requested DNS host info when the host info was already in the cache, which avoids a second lookup when the client code wants information from the cache. Signed-off-by: Craig Radcliffe <[email protected]>
chradcliffe
requested review from
alyssawilk,
lizan and
mattklein123
as code owners
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
alyssawilk
previously approved these changes
Mar 16, 2021
snowp
suggested changes
Mar 17, 2021
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Looks right to me! Should there be a test case where we verify that we get absl::nullopt back? Seems like all the added expectations assume non-empty host_info_.
Signed-off-by: Craig Radcliffe <[email protected]>
Contributor
Author
Added these assertions to existing tests in 13ca77f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
This is a follow-up to #15144 -- this change makes
loadDnsCacheEntryreturn the requested DNS host info when the host info is already in the cache. This allows client code to avoid a second lookup when the host info is needed.Additional Description: N/A
Risk Level: low - adding field to existing return struct
Testing: manual, unit testing
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A