Adds Access loggers to admin interface#15461
Merged
mattklein123 merged 33 commits intoenvoyproxy:mainfrom Mar 25, 2021
Merged
Conversation
Signed-off-by: Sotiris Nanopoulos <[email protected]>
davinci26
requested review from
PiotrSikora,
alyssawilk,
lizan and
mattklein123
as code owners
Member
Author
|
First commit to check the CI. I have some pending items still, I will tag when its ready for a review |
Signed-off-by: Sotiris Nanopoulos <[email protected]>
added 2 commits
March 12, 2021 11:40
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Merged
Signed-off-by: Sotiris Nanopoulos <[email protected]>
mattklein123
requested changes
Mar 16, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
This is great. Thanks for working on this. A few high level comments to get started.
/wait
docs/root/configuration/http/http_filters/_include/grpc-reverse-bridge-filter.yaml
Outdated
Show resolved
Hide resolved
mattklein123
requested changes
Mar 24, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM with small remaining comment. Thanks so much for working on this.
/wait
Comment on lines
+7
to
+10
| access_log: | ||
| - name: envoy.access_loggers.stdoutput | ||
| typed_config: | ||
| "@type": type.googleapis.com/envoy.extensions.access_loggers.stdoutput.v3.StdoutputAccessLog |
Member
There was a problem hiding this comment.
Now that you made it not required, how about just removing access logging entirely from all the examples? It will make them cleaner?
Signed-off-by: davinci26 <[email protected]>
Signed-off-by: davinci26 <[email protected]>
Signed-off-by: davinci26 <[email protected]>
Signed-off-by: davinci26 <[email protected]>
phlax
reviewed
Mar 24, 2021
docs/root/configuration/http/http_filters/_include/grpc-reverse-bridge-filter.yaml
Show resolved
Hide resolved
phlax
reviewed
Mar 24, 2021
phlax
reviewed
Mar 24, 2021
Signed-off-by: Sotiris Nanopoulos <[email protected]>
mattklein123
requested changes
Mar 25, 2021
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks looks great. Sorry one more test comment. Do you have test coverage of the deprecated path? I think you want a DEPRECATED_FEATURE_TEST somewhere? Thank you!
/wait
Signed-off-by: Sotiris Nanopoulos <[email protected]>
Member
Author
I did not know about this, first time contributing an API change. I added two tests to validate what happens:
|
This was referenced Apr 3, 2021
This was referenced Jun 9, 2021
codefromthecrypt
added a commit
to tetratelabs-attic/getenvoy.io
that referenced
this pull request
Jun 10, 2021
`/dev/stdout` wasn't semantically ported to windows so will crash. Also, `access_log_path` is ignored in envoy 1.19 See tetratelabs/func-e#273 See envoyproxy/envoy#15461 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
added a commit
to tetratelabs-attic/getenvoy.io
that referenced
this pull request
Jun 10, 2021
`/dev/stdout` wasn't semantically ported to windows so will crash. Also, `access_log_path` is ignored in envoy 1.19 See tetratelabs/func-e#273 See envoyproxy/envoy#15461 Co-authored-by: Takeshi Yoneda <[email protected]> Signed-off-by: Adrian Cole <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos [email protected]
Commit Message:
Splitting the work of #15202 into two pieces for easier reviewing.
Additional Description:
Risk Level: Medium
Testing: Pending
Docs Changes: Pending
Release Notes: Pending
Platform Specific Features: N/A