Implementation of bidirection kill for kill filter.#15240
Merged
htuch merged 3 commits intoenvoyproxy:mainfrom Mar 3, 2021
Merged
Implementation of bidirection kill for kill filter.#15240htuch merged 3 commits intoenvoyproxy:mainfrom
htuch merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Kevin Baichoo <[email protected]>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
qqustc
previously approved these changes
Mar 2, 2021
Contributor
Author
|
@alyssawilk since you're the maintainer on-call, can you assign maintainer to review these changes? @qqustc is an extension owner and has already signed off. Thanks! |
htuch
suggested changes
Mar 2, 2021
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM modulo minor comments.
/wait
source/extensions/filters/http/kill_request/kill_request_filter.cc
Outdated
Show resolved
Hide resolved
source/extensions/filters/http/kill_request/kill_request_filter.cc
Outdated
Show resolved
Hide resolved
| // Default to `INBOUND` if unspecified. | ||
| enum Direction { | ||
| INBOUND = 0; | ||
| OUTBOUND = 1; |
Member
There was a problem hiding this comment.
Question on whether to call this REQUEST/RESPONSE or DECODE/ENCODE?
Contributor
There was a problem hiding this comment.
decode and encode happen in each direction. Vote for REQUEST/RESPONSE
Contributor
Author
There was a problem hiding this comment.
Went with REQUEST/RESPONSE
Signed-off-by: Kevin Baichoo <[email protected]>
Signed-off-by: Kevin Baichoo <[email protected]>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Baichoo [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Modify the kill filter to support directionality.
Additional Description: This allows us to more easily test response crashes.
Risk Level: low (this is a test-only filter AFAIK)
Testing: unit test, integration test
Docs Changes: Included
Release Notes: Included
Platform Specific Features: N/A
Related Issue #14249
/assign @qqustc
Since you're one of the maintainers of the filter. PTAL.