Revert "HTTP2: Add DumpState support for HTTP2 (#14923)"#15153
Closed
rgs1 wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Revert "HTTP2: Add DumpState support for HTTP2 (#14923)"#15153rgs1 wants to merge 1 commit intoenvoyproxy:mainfrom
rgs1 wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
This reverts commit 3f740bc. Because it breaks builds on RHEL 8 and Ubuntu 18. See: envoyproxy#15093 Signed-off-by: Raul Gutierrez Segales <[email protected]>
Contributor
|
There's also been a way forward from this for several days: #15093. This handles the root cause of the breakage. Seems like @envoyproxy/senior-maintainers need to make a call. |
Contributor
Contributor
|
See also: #15154 which just replaces the for-each-n without the lint change. I hope that's less controversial 🤞 |
Member
|
We discussed and we will just disallow the breaking function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3f740bc.
Because it breaks builds on RHEL 8 and Ubuntu 18. See:
#15093
Signed-off-by: Raul Gutierrez Segales [email protected]