Lint: Lint for std::for_each_n #15093
Conversation
Signed-off-by: Kevin Baichoo <[email protected]>
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for addressing the compile issues introduced by #14923
Change looks good if we decide to avoid std::for_each_n for the time being.
|
cc @jrajahalme |
Signed-off-by: Kevin Baichoo <[email protected]>
|
I'm generally not in favor of this kind of limitation because of it is not well supported in older version of stdlib (libstdc++ <= 8). We can bump build requirement if it doesn't cause a lot of churn. |
|
@lizan I agree that limiting use of a standardized C++17 feature is not ideal, but |
|
To clarify, bumping build requirements is a potential concern for projects building on Envoy, not just Envoy itself. There is already some churn due to Envoy CI apparently using only a bleeding edge clang setup :-) |
This reverts commit 3f740bc. Because it breaks builds on RHEL 8 and Ubuntu 18. See: envoyproxy#15093 Signed-off-by: Raul Gutierrez Segales <[email protected]>
7 participants
Signed-off-by: Kevin Baichoo [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Lint: Lint for std::for_each_n
Additional Description: It's insufficiently supported in C++17. See #14923
Risk Level: low
Testing: unit test
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA