wasm: use static registration for runtimes#14014
Merged
lizan merged 7 commits intoenvoyproxy:masterfrom Nov 17, 2020
Merged
Conversation
Signed-off-by: Lizan Zhou <[email protected]>
PiotrSikora
reviewed
Nov 13, 2020
Contributor
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
Looks good, thanks! Could you verify that this works with --define wasm=disabled when some of those values evaluate to an empty list? Should we include this config in the CI?
| # webassembly common extension | ||
| /*/extensions/common/wasm @PiotrSikora @lizan | ||
| # webassembly runtimes | ||
| /*/extensions/wasm_runtime/ @PiotrSikora @lizan |
Contributor
There was a problem hiding this comment.
Any reason for not putting it under extensions/common/wasm/runtimes or similar?
Member
Author
There was a problem hiding this comment.
I don't think we put any actual extension registrations under extensions/common, extensions/common is for libraries used by extensions.
Member
Author
Windows CI or Arm64 CI does this :) |
Signed-off-by: Lizan Zhou <[email protected]>
repokitteh-read-only
bot
added
the
deps
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
Contributor
Why? V8 should work fine on both Windows and Arm64. |
PiotrSikora
previously approved these changes
Nov 14, 2020
Member
|
Check CI? /wait |
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Nov 18, 2020
* master: (117 commits) vrp: allow supervisord to open its log file (envoyproxy#14066) [http1] fix H/1 response pipelining (envoyproxy#13983) wasm: make dependency clearer (envoyproxy#14062) docs: updating 100-continue docs (envoyproxy#14040) quiche: fix stream trailer decoding issue (envoyproxy#13871) tidy: use last_github_commit script instead of target branch (envoyproxy#14052) stats: use RE2 and a better pattern to accelerate a single stats tag-extraction RE (envoyproxy#8831) wasm: use static registration for runtimes (envoyproxy#14014) grpc-json-transcoder: Add support for configuring unescaping behavior (envoyproxy#14009) ci: fix CodeQL-build by removing deprecated set-env command (envoyproxy#14046) config: fix crash when type URL doesn't match proto. (envoyproxy#14031) Build: Propagate user-supplied tags to external headers library. (envoyproxy#14016) [test host utils] use make_shared to avoid memory leaks (envoyproxy#14042) jwt_authn: update to jwt_verify_lib with 1 minute clock skew (envoyproxy#13872) quiche: update QUICHE tar (envoyproxy#13949) sds: improve watched directory documentation. (envoyproxy#14029) log the internal error message from *SSL when the cert and private key doesn't match (envoyproxy#14023) wasm: fix CPE for Wasmtime. (envoyproxy#14024) docs: Bump sphinxext-rediraffe version (envoyproxy#13996) CDS: remove warming cluster if CDS response desired (envoyproxy#13997) ...
andreyprezotto
pushed a commit
to andreyprezotto/envoy
that referenced
this pull request
Nov 24, 2020
Partially addresses envoyproxy#12574. Refactored test instantiate to removes many ifdefs. Commit Message: Additional Description: Risk Level: Low Testing: CI Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: Lizan Zhou <[email protected]>
qqustc
pushed a commit
to qqustc/envoy
that referenced
this pull request
Nov 24, 2020
Partially addresses envoyproxy#12574. Refactored test instantiate to removes many ifdefs. Commit Message: Additional Description: Risk Level: Low Testing: CI Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: Lizan Zhou <[email protected]> Signed-off-by: Qin Qin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #12574. Refactored test instantiate to removes many ifdefs.
Commit Message:
Additional Description:
Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:
Platform Specific Features:
Signed-off-by: Lizan Zhou [email protected]