examples: Add dynamic configuration (filesystem) sandbox#13783
Merged
mattklein123 merged 21 commits intoenvoyproxy:masterfrom Oct 29, 2020
Merged
examples: Add dynamic configuration (filesystem) sandbox#13783mattklein123 merged 21 commits intoenvoyproxy:masterfrom
mattklein123 merged 21 commits intoenvoyproxy:masterfrom
Conversation
phlax
changed the title
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
examples-fs-dynamic-configuration
branch
from
da85a34 to
447ba10
Compare
Signed-off-by: Ryan Northey <[email protected]>
phlax
commented
Oct 28, 2020
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
examples-fs-dynamic-configuration
branch
from
447ba10 to
d54bdc7
Compare
Member
Author
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax
commented
Oct 29, 2020
|
|
||
| .. note:: | ||
|
|
||
| If you are running on a system with strict ``umask`` you will need to ``chmod`` the dynamic config |
Member
Author
There was a problem hiding this comment.
im not over-happy with this, but after thinking about it quite a bit, it seems like the least bad option to handle the umask issue
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax
commented
Oct 29, 2020
| $ curl -s http://localhost:10000 | ||
| Request served by service1 | ||
|
|
||
| HTTP/2.0 GET / |
Member
Author
There was a problem hiding this comment.
im confused as to why this is getting HTTP/2.0 but the control plane sandbox, didnt
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax
commented
Oct 29, 2020
| ], | ||
| exclude = [ | ||
| "cache/responses.yaml", | ||
| "dynamic-config-fs/**/*", |
Member
Author
There was a problem hiding this comment.
this isnt ideal, but theres not an obvious way to include the dynamic yaml without it being treated as a standalone envoy config
at least this config gets tested in the sandbox
Member
There was a problem hiding this comment.
Hmm yeah. I think we could probably config check these separately somehow but not a huge deal for now.
phlax
changed the title
Signed-off-by: Ryan Northey <[email protected]>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
phlax
commented
Oct 29, 2020
phlax
commented
Oct 29, 2020
phlax
commented
Oct 29, 2020
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Member
Author
|
this one should be ready for final review |
mattklein123
approved these changes
Oct 29, 2020
| $ curl -s http://localhost:10000 | ||
| Request served by service1 | ||
|
|
||
| HTTP/2.0 GET / |
| ], | ||
| exclude = [ | ||
| "cache/responses.yaml", | ||
| "dynamic-config-fs/**/*", |
Member
There was a problem hiding this comment.
Hmm yeah. I think we could probably config check these separately somehow but not a huge deal for now.
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 30, 2020
* master: dns: preserve custom resolver after channel destruction (envoyproxy#13820) docs: Further updates to quick-start (envoyproxy#13793) wasm: update V8 to v8.7.220.10. (envoyproxy#13568) test: adding a test for CONNECT to an IP address (envoyproxy#13818) [fuzz] Scaled Load balancer fuzz to 60k hosts (envoyproxy#13771) Removed Circle-CI reference. (envoyproxy#13824) wasm: strip only Custom Sections with precompiled Wasm modules. (envoyproxy#13775) examples: Add dynamic configuration (filesystem) sandbox (envoyproxy#13783) apple dns: resolve IP addresses without calling Apple APIs (envoyproxy#13698) Signed-off-by: Michael Puncel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey [email protected]
Commit Message: examples: Add dynamic configuration (filesystem) sandbox
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]