HTTP health checker: handle GOAWAY from HTTP2 upstreams#13599
Merged
mattklein123 merged 51 commits intoenvoyproxy:masterfrom Jan 12, 2021
Merged
HTTP health checker: handle GOAWAY from HTTP2 upstreams#13599mattklein123 merged 51 commits intoenvoyproxy:masterfrom
mattklein123 merged 51 commits intoenvoyproxy:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the HTTP health checker handle GOAWAY properly. When the NO_ERROR
code is received, any in flight request will be allowed to complete, at
which time the connection will be closed and a new connection created on
the next interval.
GOAWAY frames with codes other than NO_ERROR are treated as a health
check failure, and immediately close the connection.
Commit Message:
Makes the HTTP health checker handle GOAWAY properly. When the NO_ERROR
code is received, any in flight request will be allowed to complete, at
which time the connection will be closed and a new connection created on
the next interval.
GOAWAY frames with codes other than NO_ERROR are treated as a health
check failure, and immediately close the connection.
Additional Description:
I verified this locally with the same setup as the described issue, and saw the desired behavior.
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: Included
Fixes #13544