docs: Update build instructions for docs#13268
Merged
htuch merged 8 commits intoenvoyproxy:masterfrom Sep 30, 2020
Merged
Conversation
Signed-off-by: Ryan Northey <[email protected]>
phlax
commented
Sep 25, 2020
phlax
commented
Sep 25, 2020
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
phlax
commented
Sep 25, 2020
htuch
suggested changes
Sep 27, 2020
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks, this is a nice improvement!
/wait
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
htuch
reviewed
Sep 30, 2020
docs/README.md
Outdated
| This can be done as follows: | ||
|
|
||
| ``` | ||
| ./ci/run_envoy_docker.sh 'ci/do_ci.sh docs' |
Member
There was a problem hiding this comment.
One extra ask. I'm about to add some additional validation stuff to the docs target for CI checking on external dependency metadata that feeds into docs. Can you make a fork of this docs target called dev_docs (or something like that), so that we don't have developers running the more expensive target locally?
Member
Author
There was a problem hiding this comment.
Its not actually necessary to use the do_ci.sh script at all - ie you can use docs/build.sh directly inside the container.
Ive updated to use build.sh
Signed-off-by: Ryan Northey <[email protected]>
Member
Author
|
i think the mac test fail is unrelated - its been failing all day on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey [email protected]
Commit Message: docs: Update build instructions for docs
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue] Partial fix for #13229
[Optional Deprecated:]