Revert "pgv: update (#12025)"#12100
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jul 15, 2020
Merged
Conversation
This reverts commit ca7dc53. Signed-off-by: James Buckland <[email protected]>
Contributor
Author
|
/retest |
|
🤷♀️ nothing to rebuild. |
htuch
approved these changes
Jul 15, 2020
Member
|
@Shikugawa the issue is that we never tested with the real repository_locations.bzl, since fix format wasn't run and it didn't get copied to Can you do a new PGV update that validates after fix format? Ideally we have a check_format that verifies that |
KBaichoo
pushed a commit
to KBaichoo/envoy
that referenced
this pull request
Jul 30, 2020
This reverts commit ca7dc53. This PGV upgrade is breaking my local build. Risk Level: Low Testing: N/a Signed-off-by: James Buckland <[email protected]> Signed-off-by: Kevin Baichoo <[email protected]>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
This reverts commit ca7dc53. This PGV upgrade is breaking my local build. Risk Level: Low Testing: N/a Signed-off-by: James Buckland <[email protected]> Signed-off-by: scheler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: This reverts commit ca7dc53.
Additional Description: This PGV upgrade is breaking my local build.
Risk Level: Low
Testing: N/a
Docs Changes: N/a
Release Notes: N/a
Signed-off-by: James Buckland [email protected]