Skip to content

Add missing words to dictionary#10763

Closed
Augustyniak wants to merge 4 commits intoenvoyproxy:masterfrom
Augustyniak:fix-spell-checking
Closed

Add missing words to dictionary#10763
Augustyniak wants to merge 4 commits intoenvoyproxy:masterfrom
Augustyniak:fix-spell-checking

Conversation

@Augustyniak
Copy link
Copy Markdown
Contributor

@Augustyniak Augustyniak commented Apr 14, 2020 •
edited
Loading

44eedc7 broke spell checking that's run as part of the git pre-push hook. This PR is supposed to fix it by adding new words to dictionary.

Running git push prior to the fix:

Checking format for third_party/statusor/statusor.cc - PASS
Checking spelling for third_party/statusor/statusor.cc
third_party/statusor/statusor.cc:7: * Copyright 2019 Google LLC
third_party/statusor/statusor.cc:41:} // namespace internal_statusor
Checked 1 file(s) and 22 comment(s), found 2 error(s).
ERROR: spell check failed. Run 'tools/spelling/check_spelling_pedantic.py fix and/or add new words to tools/spelling/spelling_dictionary.txt'

Running tools/spelling/check_spelling_pedantic.py fix with the fix in:

Checked 2964 file(s) and 84314 comment(s), found 0 error(s).

Signed-off-by: Rafal Augustyniak [email protected]

@Augustyniak
Add missing words to dictionary
29c9f43 
Signed-off-by: Rafal Augustyniak <[email protected]>
@Augustyniak Augustyniak mentioned this pull request Apr 14, 2020
Merged
@Augustyniak
Merge remote-tracking branch 'upstream/master' into fix-spell-checking
a36a73f 
Signed-off-by: Rafal Augustyniak <[email protected]>
@Augustyniak
add one more word
1d82494 
Signed-off-by: Rafal Augustyniak <[email protected]>
@Augustyniak
fix
60ce179 
Signed-off-by: Rafal Augustyniak <[email protected]>
@yanavlasov
Copy link
Copy Markdown
Contributor

yanavlasov commented Apr 14, 2020

Hmm, it looks like I missed the exclusion of the third_party in spell checker. The correct fix is to not check the third_party directory content at all. I will fix this.

@yanavlasov yanavlasov closed this Apr 14, 2020
@yanavlasov
Copy link
Copy Markdown
Contributor

yanavlasov commented Apr 14, 2020

Actually how does your git hook invokes tools/spelling/check_spelling_pedantic.py ? By default the script should not check third_partry.

@Augustyniak
Copy link
Copy Markdown
Contributor Author

Augustyniak commented Apr 14, 2020

  1. I used standard git hook that comes with Envoy
  2. I run tools/spelling/check_spelling_pedantic.py manually just to confirm that everything works - it was not involved by my git hook.

@yanavlasov
Copy link
Copy Markdown
Contributor

yanavlasov commented Apr 15, 2020

Just to make sure. Does this tools/spelling/check_spelling_pedantic.py check fails for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Augustyniak @yanavlasov