DRAFT: Proxy Protocol Transport Socket #10682
Closed
wez470 wants to merge 3 commits intoenvoyproxy:masterfrom
wez470:proxy-proto-all
Closed
DRAFT: Proxy Protocol Transport Socket #10682wez470 wants to merge 3 commits intoenvoyproxy:masterfrom wez470:proxy-proto-all
wez470 wants to merge 3 commits intoenvoyproxy:masterfrom
wez470:proxy-proto-all
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened this because I wanted to discuss / get some feedback on a few things. I am thinking I can split the rest of this work into 2 PRs (Maybe 3?). Contents would be as follows:
PR 1:
PR 2:
PR 3:
This branch currently has PR 1 and some parts of what would be PR 2 in it. I'd just move the PR 1 pieces to a separate branch. Thoughts? I've also left a comment with a question on some code.
@alyssawilk @mattklein123
edit - Just noticed that v2 xDS is now frozen. So I'll have to update that.