listener: in place filter chain update#10662
Merged
mattklein123 merged 33 commits intoenvoyproxy:masterfrom Apr 30, 2020
Merged
listener: in place filter chain update#10662mattklein123 merged 33 commits intoenvoyproxy:masterfrom
mattklein123 merged 33 commits intoenvoyproxy:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Provide new listener update path which could update the filter chains without draining all the connections of the old listener.
The in place filter chain update flow is an optimization of listener update. If the supportUpdateFilterChain() passes and runtime
"envoy.reloadable_features.listener_in_place_filterchain_update" is not explicitly disabled,
the existing connections may not be drained if the owning filter chains are not updated in the new listener config.
Additional Description:
patch 3/N of #9773
Follow up of #10528
This PR is providing new listener update path guarded by supportUpdateFilterChain()
The in place filter chain update flow is an optimization of listener update. If the above check pass and runtime
"envoy.reloadable_features.listener_in_place_filterchain_update" is not explicitly disabled,
the existing connections may not be drained if the owning filter chains are not updated in the new listener config.
When the feature is disabled by the runtime, the following listener update won't use the optimized path.
The new update flow starts with the construction of
ListenerImpl.ListenerImpl will share PerListenerFactoryContext, and the warmup callback utilize the below worker interface
Those 2 methods are landed in worker: provide removeFilterChain interface #10528
Risk Level: Medium
Connection life time changes by default. Can be disabled by setting "envoy.reloadable_features.listener_in_place_filterchain_update" to false.
Testing: integration test,unit test, runtime flag test.
Docs Changes:
Release Notes: see current.rst