Skip to content

[release/v1.13] string matcher: add ignore_case to StringMatcher (#9868)#10016

Merged
PiotrSikora merged 1 commit intoenvoyproxy:release/v1.13from
yangminzhu:ignore-case-13
Feb 12, 2020
Merged

[release/v1.13] string matcher: add ignore_case to StringMatcher (#9868)#10016
PiotrSikora merged 1 commit intoenvoyproxy:release/v1.13from
yangminzhu:ignore-case-13

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

Signed-off-by: Yangmin Zhu [email protected]

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: cherry-pick #9868 to 1.13
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10016 was opened by yangminzhu.

see: more, trace.

@lizan
Copy link
Copy Markdown
Member

lizan commented Feb 12, 2020

@PiotrSikora I think we need PR like https://github.com/envoyproxy/envoy/pull/9750/files before back porting otherwise the version output will be weird.

@lizan
Copy link
Copy Markdown
Member

lizan commented Feb 12, 2020

/azp run envoy-linux

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@PiotrSikora
Copy link
Copy Markdown
Contributor

@lizan good call, see #10025 #10026.

/wait

@PiotrSikora
Copy link
Copy Markdown
Contributor

@mattklein123 we probably shouldn't guard api/ changes in stable releases on @envoyproxy/api-shepherds, since those are all backports of approved changes.

@PiotrSikora
Copy link
Copy Markdown
Contributor

Skipping @envoyproxy/api-shepherds review (see: #10035).

@PiotrSikora PiotrSikora merged commit 6227c28 into envoyproxy:release/v1.13 Feb 12, 2020
@yangminzhu yangminzhu deleted the ignore-case-13 branch February 12, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants