Skip to content

[delta-xds] do not populate resource_names_subscribe with existing resources on reconnection for "wildcard" XDSes #16063

@stevenzzzz

Description

@stevenzzzz

Title: Since LDS/CDS/SRDS are wildcard XDSes, we should not populate the resource_names_subscribe with existing resources.

Description:
On reconnection, DeltaXDS packs the already subscribed resources into resource_names_subscribe, which is used to mean "new subscription interests", this is confusing on the management server side since for "wildcard XDSes"( CDS/LDS/SRDS) it expects an empty resource list

https://github.com/envoyproxy/envoy/blob/main/source/common/config/delta_subscription_state.cc#L169-L182

We should also revisit this decision of "packing existing resources into resource_names_subscribe on reconnection" since
the "interests of these resources" is already expressed via initial_resource_versions.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions