Address PR comments

Sotiris Nanopoulos · Sotiris Nanopoulos · commit d540ffd472c7 · 2020-08-14T09:57:16.000-07:00
Signed-off-by: Sotiris Nanopoulos &lt;sonanopo@microsoft.com&gt;
diff --git a/test/extensions/filters/listener/http_inspector/BUILD b/test/extensions/filters/listener/http_inspector/BUILD
@@ -16,8 +16,9 @@ envoy_extension_cc_test(
     srcs = ["http_inspector_test.cc"],
     extension_name = "envoy.filters.listener.http_inspector",
     #TODO(davinci26): The test passes on Windows *but* http inspector
-    # relies on Event::FileTriggerType::Edge and we get away with it
-    # because we mock the dispather.
+    # *used* to rely on Event::FileTriggerType::Edge and we got away with it
+    # because we mock the dispatcher. Need to verify that the scenario is 
+    # actually working.
     tags = ["fails_on_windows"],
     deps = [
         "//source/common/common:hex_lib",
diff --git a/test/extensions/filters/listener/http_inspector/http_inspector_test.cc b/test/extensions/filters/listener/http_inspector/http_inspector_test.cc
@@ -567,6 +567,9 @@ TEST_F(HttpInspectorTest, MultipleReadsHttp1BadProtocol) {
 }
 
 TEST_F(HttpInspectorTest, Http1WithLargeRequestLine) {
+  // Verify that the http inspector can detect http requests
+  // with large request line even when they are splitted over
+  // multiple recv calls.
   init();
   absl::string_view method = "GET", http = "/index HTTP/1.0\r";
   std::string spaces(Config::MAX_INSPECT_SIZE - method.size() - http.size(), ' ');
@@ -591,11 +594,12 @@ TEST_F(HttpInspectorTest, Http1WithLargeRequestLine) {
                                                        int) -> Api::SysCallSizeResult {
           size_t len = (*ctr);
           if (num_loops == 2) {
+            ASSERT(*ctx != 3)
             len = size_t(Config::MAX_INSPECT_SIZE / (3 - (*ctr)));
           }
           ASSERT(length >= len);
           memcpy(buffer, data.data(), len);
-          (*ctr) += 1;
+          *ctr += 1;
           return Api::SysCallSizeResult{ssize_t(len), 0};
         }));
   }
