Add todo addressing embedded assumption about allocator fallback

ambuc · ambuc · commit cb0fd8a04214 · 2018-07-12T13:46:07.000-04:00
Signed-off-by: James Buckland &lt;jbuckland@google.com&gt;
diff --git a/source/common/stats/thread_local_store.cc b/source/common/stats/thread_local_store.cc
@@ -182,6 +182,11 @@ StatType& ThreadLocalStoreImpl::ScopeImpl::safeMakeStat(
         make_stat(parent_.alloc_, name, std::move(tag_extracted_name), std::move(tags));
     if (stat == nullptr) {
       parent_.num_last_resort_stats_.inc();
+      // TODO(jbuckland) Performing the fallback from non-heap allocator to heap allocator should be
+      // the responsibility of the non-heap allocator, not the client of the non-heap allocator.
+      // This branch will never be used in the non-hot-restart case, since the parent_.alloc_ object
+      // will throw instead of returning a nullptr; we should remove the assumption that this
+      // branching case is always available.
       stat =
           make_stat(parent_.heap_allocator_, name.substr(0, parent_.statsOptions().maxNameLength()),
                     std::move(tag_extracted_name), std::move(tags));
