Don't build tag string unless using tag

taiki45 · taiki45 · commit 80560ce3e41f · 2017-12-07T17:31:26.000+09:00
Signed-off-by: Taiki Ono &lt;taiks.4559@gmail.com&gt;
diff --git a/source/common/stats/statsd.cc b/source/common/stats/statsd.cc
@@ -83,8 +83,8 @@ std::string UdpStatsdSink::getName(const Metric& metric) {
   }
 }
 
-const std::string buildTagStr(const std::vector<Tag>& tags) {
-  if (tags.empty()) {
+const std::string UdpStatsdSink::buildTagStr(const std::vector<Tag>& tags) {
+  if (!useTag_ || tags.empty()) {
     return {};
   }
 
diff --git a/source/common/stats/statsd.h b/source/common/stats/statsd.h
@@ -58,13 +58,13 @@ class UdpStatsdSink : public Sink {
 
 private:
   std::string getName(const Metric& metric);
+  const std::string buildTagStr(const std::vector<Tag>& tags);
 
   ThreadLocal::SlotPtr tls_;
   Network::Address::InstanceConstSharedPtr server_address_;
   bool useTag_;
 };
 
-const std::string buildTagStr(const std::vector<Tag>& tags);
 
 /**
  * Per thread implementation of a TCP stats flusher for statsd.

Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,8 @@ std::string UdpStatsdSink::getName(const Metric& metric) {`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`
`86`		`-const std::string buildTagStr(const std::vector<Tag>& tags) {`
`87`		`- if (tags.empty()) {`
	`86`	`+const std::string UdpStatsdSink::buildTagStr(const std::vector<Tag>& tags) {`
	`87`	`+ if (!useTag_ \|\| tags.empty()) {`
`88`	`88`	`return {};`
`89`	`89`	`}`
`90`	`90`